yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811092332
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -168,33 +167,35 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> WRITE_PAYLOAD_CLASS_NAME =
ConfigProperty
.key("hoodie.datasource.write.payload.class")
- .defaultValue(DefaultHoodieRecordPayload.class.getName())
+ .noDefaultValue()
.markAdvanced()
+ .deprecatedAfter("1.0.0")
.withDocumentation("Payload class used. Override this, if you like to
roll your own merge logic, when upserting/inserting. "
+ "This will render any value set for PRECOMBINE_FIELD_OPT_VAL
in-effective");
- public static final ConfigProperty<String> WRITE_PAYLOAD_TYPE =
ConfigProperty
- .key("hoodie.datasource.write.payload.type")
- .defaultValue(RecordPayloadType.HOODIE_AVRO_DEFAULT.name())
- .markAdvanced()
+ public static final ConfigProperty<String> RECORD_MERGE_MODE = ConfigProperty
+ .key("hoodie.write.record.merge.mode")
+ .defaultValue(RecordMergeMode.EVENT_TIME_ORDERING.name())
.sinceVersion("1.0.0")
- .withDocumentation(RecordPayloadType.class);
+ .withDocumentation(RecordMergeMode.class);
public static final ConfigProperty<String> RECORD_MERGER_IMPLS =
ConfigProperty
- .key("hoodie.datasource.write.record.merger.impls")
- .defaultValue(HoodieAvroRecordMerger.class.getName())
+ .key("hoodie.write.record.merge.custom.impl.classes")
+ .noDefaultValue()
.markAdvanced()
+ .withAlternatives("hoodie.datasource.write.record.merger.impls")
.sinceVersion("0.13.0")
.withDocumentation("List of HoodieMerger implementations constituting
Hudi's merging strategy -- based on the engine used. "
- + "These merger impls will filter by
hoodie.datasource.write.record.merger.strategy "
+ + "These merger impls will filter by
hoodie.write.record.merge.strategy "
+ "Hudi will pick most efficient implementation to perform
merging/combining of the records (during update, reading MOR table, etc)");
- public static final ConfigProperty<String> RECORD_MERGER_STRATEGY =
ConfigProperty
- .key("hoodie.datasource.write.record.merger.strategy")
- .defaultValue(HoodieRecordMerger.DEFAULT_MERGER_STRATEGY_UUID)
+ public static final ConfigProperty<String> RECORD_MERGER_STRATEGY_ID =
ConfigProperty
Review Comment:
Make sure all variable names are consistent.
```suggestion
public static final ConfigProperty<String> RECORD_MERGE_STRATEGY_ID =
ConfigProperty
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
