yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811111186
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -621,25 +621,6 @@ private void flushToDiskIfRequired(HoodieRecord record,
boolean appendDeleteBloc
}
}
- private HoodieLogBlock.HoodieLogBlockType pickLogDataBlockFormat() {
- Option<HoodieLogBlock.HoodieLogBlockType> logBlockTypeOpt =
config.getLogDataBlockFormat();
- if (logBlockTypeOpt.isPresent()) {
- return logBlockTypeOpt.get();
- }
-
- // Fallback to deduce data-block type based on the base file format
- switch (hoodieTable.getBaseFileFormat()) {
- case PARQUET:
- case ORC:
- return HoodieLogBlock.HoodieLogBlockType.AVRO_DATA_BLOCK;
- case HFILE:
Review Comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
