yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811580268
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/HoodieSparkValidateDuplicateKeyRecordMerger.scala:
##########
@@ -43,5 +45,9 @@ class HoodieSparkValidateDuplicateKeyRecordMerger extends
HoodieSparkRecordMerge
/**
* The kind of merging strategy this recordMerger belongs to. An UUID
represents merging strategy.
*/
- override def getMergingStrategy: String =
HoodieRecordMerger.DEFAULT_MERGER_STRATEGY_UUID
+ override def getMergingStrategy: String = STRATEGY_STR
+}
+
+object HoodieSparkValidateDuplicateKeyRecordMerger {
+ final val STRATEGY_STR = "fb092649-0fdc-4c14-9113-acde3034a6c4"
Review Comment:
Let's have a Jira ticket to track that. In the current scheme, it's still
hard to avoid collision, since there is no rule on how to generate these IDs.
A general String with namespace and number might be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
