yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811566426
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -104,10 +98,9 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext,
this.props = props;
this.start = start;
this.length = length;
- this.recordMergeMode = getRecordMergeMode(props);
HoodieTableConfig tableConfig = hoodieTableMetaClient.getTableConfig();
- this.recordMerger =
readerContext.getRecordMerger(tableConfig.getRecordMergerStrategy());
- readerContext.setRecordMerger(this.recordMerger);
+
readerContext.setRecordMerger(readerContext.getRecordMerger(tableConfig.getRecordMergeMode(),
+ tableConfig.getRecordMergerStrategy(),
props.getString("hoodie.datasource.write.record.merger.impl","")));
Review Comment:
Let's define the config name in final strings so we can clean them up in the
future if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
