yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811567454
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReaderSchemaHandler.java:
##########
@@ -162,6 +165,31 @@ private Schema generateRequiredSchema() {
return appendFieldsToSchemaDedupNested(requestedSchema, addedFields);
}
+ private static String[] getMandatoryFieldsForMerging(HoodieTableConfig cfg,
Option<HoodieRecordMerger> recordMerger) {
+ if (cfg.getRecordMergeMode() == RecordMergeMode.CUSTOM) {
+ return recordMerger.get().getMandatoryFieldsForMerging(cfg);
Review Comment:
Let's create a follow-up Jira ticket on this since it requires more work to
make the usability better. Right now the user must provide
`getMandatoryFieldsForMerging` to make sure the functionality is correct, which
is OK as long as we update the docs (let's add a Jira ticket too).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
