KnightChess commented on code in PR #12242:
URL: https://github.com/apache/hudi/pull/12242#discussion_r1840133523
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala:
##########
@@ -132,12 +133,10 @@ class ExpressionPayload(@transient record: GenericRecord,
.serialize(resultingRow)
.asInstanceOf[GenericRecord]
- if (targetRecord.isEmpty ||
needUpdatingPersistedRecord(targetRecord.get, resultingAvroRecord, properties))
{
- resultRecordOpt = HOption.of(resultingAvroRecord)
+ resultRecordOpt = if (targetRecord.isEmpty) {
Review Comment:
the method is `processMatchedRecord`, why we need judge targetRecord is
empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
