nsivabalan commented on code in PR #12242:
URL: https://github.com/apache/hudi/pull/12242#discussion_r1844319669
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -464,6 +464,11 @@ case class MergeIntoHoodieTableCommand(mergeInto:
MergeIntoTable) extends Hoodie
PAYLOAD_EXPECTED_COMBINED_SCHEMA ->
encodeAsBase64String(toStructType(joinedExpectedOutput))
)
+ // Append original payload class
+ writeParams ++= Seq(
+ PAYLOAD_ORIGINAL_AVRO_PAYLOAD ->
hoodieCatalogTable.tableConfig.getPayloadClass
+ )
Review Comment:
If we plan to support the payload class in table config for MIT, then should
we consider extending ExpressionPayload from BaseAvroPayload instead of
DefaultHoodieRecordPayload?
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -464,6 +464,11 @@ case class MergeIntoHoodieTableCommand(mergeInto:
MergeIntoTable) extends Hoodie
PAYLOAD_EXPECTED_COMBINED_SCHEMA ->
encodeAsBase64String(toStructType(joinedExpectedOutput))
)
+ // Append original payload class
+ writeParams ++= Seq(
+ PAYLOAD_ORIGINAL_AVRO_PAYLOAD ->
hoodieCatalogTable.tableConfig.getPayloadClass
+ )
Review Comment:
If we plan to honor the payload class in table config for MIT, then should
we consider extending ExpressionPayload from BaseAvroPayload instead of
DefaultHoodieRecordPayload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
