nsivabalan commented on code in PR #12242:
URL: https://github.com/apache/hudi/pull/12242#discussion_r1844328327
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala:
##########
@@ -164,6 +163,34 @@ class ExpressionPayload(@transient record: GenericRecord,
}
}
+ private def doRecordMerge(incomingRecord: GenericRecord,
+ existingRecord: IndexedRecord,
+ schema: Schema,
+ properties: Properties): HOption[IndexedRecord] = {
+ val tablePayloadClass =
properties.getProperty(PAYLOAD_ORIGINAL_AVRO_PAYLOAD)
+ if
(tablePayloadClass.equals(classOf[OverwriteWithLatestAvroPayload].getName)) {
+ HOption.of(incomingRecord)
+ } else if
(tablePayloadClass.equals(classOf[DefaultHoodieRecordPayload].getName)) {
+ if (needUpdatingPersistedRecord(existingRecord, incomingRecord,
properties)) {
Review Comment:
there is some more logic in combineAndGetUpdateValue of
DefaultHoodieRecordPayload which we are bypassing here. it might be better if
we call into the DefaultHoodieRecordPayload.combineAndGetUpdateValue only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
