prashantwason commented on a change in pull request #2064:
URL: https://github.com/apache/hudi/pull/2064#discussion_r491220125
##########
File path:
hudi-client/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java
##########
@@ -230,6 +231,9 @@ protected void commit(Option<Map<String, String>>
extraMetadata, HoodieWriteMeta
metadata.addMetadata(HoodieCommitMetadata.SCHEMA_KEY,
getSchemaToStoreInCommit());
metadata.setOperationType(operationType);
+ // Update Metadata Table
+ HoodieMetadata.update(config, metadata, instantTime);
Review comment:
I observed that certain commit paths do not go via the HoodieWriteCLient
(HoodieWriteClient.completeCompaction(), AbstractHoodieClient.commitStats())
as they have been moved into the various executors. Hence, I could not find a
single location which would be sufficient to issue the HoodieMetadata.update.
This is also the reason I could not use a member variable in
HoodieWriteClient as you had suggested elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
