prashantwason commented on a change in pull request #2064:
URL: https://github.com/apache/hudi/pull/2064#discussion_r491313138
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -884,6 +921,15 @@ public Builder withCompactionConfig(HoodieCompactionConfig
compactionConfig) {
return this;
}
+ public Builder withMetadataCompactionConfig(HoodieCompactionConfig
compactionConfig) throws IOException {
+ // Since the property names from HoodieCompactionConfig are already used
in withCompactionConfig,
Review comment:
I feel this will be lots of redundant code especially when we start
having other internal tables which will have their own compaction configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
