prashantwason commented on a change in pull request #2064: URL: https://github.com/apache/hudi/pull/2064#discussion_r491315758
########## File path: hudi-client/src/main/java/org/apache/hudi/metadata/HoodieMetadata.java ########## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata; + +import java.io.IOException; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.avro.model.HoodieCleanerPlan; +import org.apache.hudi.avro.model.HoodieRestoreMetadata; +import org.apache.hudi.avro.model.HoodieRollbackMetadata; +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.model.HoodieCommitMetadata; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieMetadataException; +import org.apache.hudi.exception.TableNotFoundException; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; +import org.apache.spark.api.java.JavaSparkContext; + +/** + * Defines the interface through which file listing metadata is created, updated and accessed. This metadata is + * saved within an internal Metadata Table. + * + * If file listing metadata is disabled, the functions default to using listStatus(...) RPC calls to retrieve + * file listings from the file system. + */ +public class HoodieMetadata { + private static final Logger LOG = LogManager.getLogger(HoodieMetadata.class); + + // Instances of metadata for each basePath + private static Map<String, HoodieMetadataImpl> instances = new HashMap<>(); Review comment: Each time you create an instance of this class, it needs to load the timeline and check for sync, etc. So ideally an instance should be created only once. But the HoodieMetadata is being used in multiple classes (HoodieWriteClient and various XXXCommitActionExectors) so I could not just keep it at one place. >> Unless we are doing something here across multiple base paths, Yes, we have a usecase in ETL where the same data is written to multiple HUDI tables (cell / row) in parallel. Hence, we need this to be a map. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
