codope commented on code in PR #12288:
URL: https://github.com/apache/hudi/pull/12288#discussion_r1855250215


##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -579,16 +603,27 @@ private static void 
createTableLayoutOnStorage(StorageConfiguration<?> storageCo
     if (!storage.exists(metaPathDir)) {
       storage.createDirectory(metaPathDir);
     }
+
     // create schema folder
     StoragePath schemaPathDir = new StoragePath(metaPathDir, 
SCHEMA_FOLDER_NAME);
     if (!storage.exists(schemaPathDir)) {
       storage.createDirectory(schemaPathDir);
     }
 
+    // if anything other than default archive log folder is specified, create 
that too
+    String timelinePropVal = new 
HoodieConfig(props).getStringOrDefault(TIMELINE_FOLDER);
+    StoragePath timelineDir = metaPathDir;
+    if (!StringUtils.isNullOrEmpty(timelinePropVal)) {
+      timelineDir = new StoragePath(metaPathDir, timelinePropVal);
+      if (!storage.exists(timelineDir)) {

Review Comment:
   this does not lie on the hotpath.. only called while initTable()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to