codope commented on code in PR #12288:
URL: https://github.com/apache/hudi/pull/12288#discussion_r1855250715


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToSevenDowngradeHandler.java:
##########
@@ -71,6 +77,28 @@ public class EightToSevenDowngradeHandler implements 
DowngradeHandler {
   private static final Logger LOG = 
LoggerFactory.getLogger(EightToSevenDowngradeHandler.class);
   private static final Set<String> SUPPORTED_METADATA_PARTITION_PATHS = 
getSupportedMetadataPartitionPaths();
 
+  /**
+   * Extract Epoch time from completion time string
+   * @param instant : HoodieInstant
+   * @return
+   */
+  public static long convertCompletionTimeToEpoch(HoodieInstant instant) {

Review Comment:
   moved this method to `UpgradeDowngradeUtils` and added a test in 
`TestUpgradeDowngradeUtils`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to