codope commented on code in PR #12288:
URL: https://github.com/apache/hudi/pull/12288#discussion_r1855250626
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -179,6 +183,8 @@ protected HoodieTableMetaClient(HoodieStorage storage,
String basePath, boolean
}
this.timelineLayoutVersion = layoutVersion.orElseGet(() ->
tableConfig.getTimelineLayoutVersion().get());
this.timelineLayout = TimelineLayout.fromVersion(timelineLayoutVersion);
+ this.activeTimelinePath =
timelineLayout.getTimelinePathProvider().getActiveTimelinePath(tableConfig,
this.basePath);
Review Comment:
rename these methods here and variables in metaClient to `timelinePath` and
`timelineHistoryPath`. I can takeup the removal of `archived` as a followup.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -222,9 +222,14 @@ public class HoodieTableConfig extends HoodieConfig {
public static final ConfigProperty<String> ARCHIVELOG_FOLDER = ConfigProperty
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
