danny0405 commented on code in PR #12384:
URL: https://github.com/apache/hudi/pull/12384#discussion_r1864729324
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/HoodieCompactor.java:
##########
@@ -130,8 +151,14 @@ public HoodieData<WriteStatus> compact(
TaskContextSupplier taskContextSupplier = table.getTaskContextSupplier();
// if this is a MDT, set up the instant range of log reader just like
regular MDT snapshot reader.
Option<InstantRange> instantRange =
CompactHelpers.getInstance().getInstantRange(metaClient);
+
+ // Broadcast necessary information.
+ Option<CompactorBroadcastManager> broadcastManagerOpt =
getCompactorBroadcastManager(context);
Review Comment:
> and partial update is just a part of it. So emphasizing partial update is
too specific.
+1
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/HoodieCompactor.java:
##########
@@ -130,8 +151,14 @@ public HoodieData<WriteStatus> compact(
TaskContextSupplier taskContextSupplier = table.getTaskContextSupplier();
// if this is a MDT, set up the instant range of log reader just like
regular MDT snapshot reader.
Option<InstantRange> instantRange =
CompactHelpers.getInstance().getInstantRange(metaClient);
+
+ // Broadcast necessary information.
+ Option<CompactorBroadcastManager> broadcastManagerOpt =
getCompactorBroadcastManager(context);
Review Comment:
> and partial update is just a part of it. So emphasizing partial update is
too specific.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
