linliu-code commented on code in PR #12384:
URL: https://github.com/apache/hudi/pull/12384#discussion_r1864748380
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -582,7 +582,7 @@ object DataSourceWriteOptions {
val ENABLE_MERGE_INTO_PARTIAL_UPDATES: ConfigProperty[Boolean] =
ConfigProperty
.key("hoodie.spark.sql.merge.into.partial.updates")
- .defaultValue(true)
+ .defaultValue(false)
Review Comment:
I think @yihua and @nsivabalan want to use the config to control the
compaction code path based on partial updates. Therefore, logically the default
value should false; otherwise, the flag is meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
