linliu-code commented on code in PR #12384:
URL: https://github.com/apache/hudi/pull/12384#discussion_r1864740750
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/HoodieSparkCopyOnWriteTable.java:
##########
@@ -112,12 +112,12 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>>
upsert(HoodieEngineContext c
@Override
public HoodieWriteMetadata<HoodieData<WriteStatus>>
insert(HoodieEngineContext context, String instantTime,
HoodieData<HoodieRecord<T>> records) {
- return new
SparkInsertCommitActionExecutor<>((HoodieSparkEngineContext)context, config,
this, instantTime, records).execute();
+ return new SparkInsertCommitActionExecutor<>((HoodieSparkEngineContext)
context, config, this, instantTime, records).execute();
}
@Override
public HoodieWriteMetadata<HoodieData<WriteStatus>>
bulkInsert(HoodieEngineContext context, String instantTime,
HoodieData<HoodieRecord<T>> records,
- Option<BulkInsertPartitioner> userDefinedBulkInsertPartitioner) {
+
Option<BulkInsertPartitioner> userDefinedBulkInsertPartitioner) {
Review Comment:
yes, I thought they should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
