linliu-code commented on code in PR #12524:
URL: https://github.com/apache/hudi/pull/12524#discussion_r1893306206
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodiePositionBasedFileGroupRecordBuffer.java:
##########
@@ -268,13 +268,10 @@ protected boolean shouldSkip(T record, String
keyFieldName, boolean isFullKey, S
}
// When the record key matches with one of the keys or key prefixes, can
not skip.
- if ((isFullKey && keys.contains(recordKey))
- || (!isFullKey && keys.stream().anyMatch(recordKey::startsWith))) {
- return false;
- }
+ return (!isFullKey || !keys.contains(recordKey))
Review Comment:
lgtm!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
