yihua commented on code in PR #12524:
URL: https://github.com/apache/hudi/pull/12524#discussion_r1893317303
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/AsyncClusteringService.java:
##########
@@ -47,7 +47,7 @@ public abstract class AsyncClusteringService extends
HoodieAsyncTableService {
private static final Logger LOG =
LoggerFactory.getLogger(AsyncClusteringService.class);
private final int maxConcurrentClustering;
protected transient HoodieEngineContext context;
- private transient BaseClusterer clusteringClient;
+ private final transient BaseClusterer clusteringClient;
Review Comment:
See
https://stackoverflow.com/questions/2968876/final-transient-fields-and-serialization
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncService.java:
##########
@@ -57,11 +57,11 @@ public abstract class HoodieAsyncService implements
Serializable {
// Run in daemon mode
private final boolean runInDaemonMode;
// Queue to hold pending compaction/clustering instants
- private transient BlockingQueue<String> pendingInstants = new
LinkedBlockingQueue<>();
+ private final transient BlockingQueue<String> pendingInstants = new
LinkedBlockingQueue<>();
Review Comment:
Similar here for double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
