yihua commented on code in PR #12524:
URL: https://github.com/apache/hudi/pull/12524#discussion_r1893320221
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/WorkloadStat.java:
##########
@@ -33,9 +33,9 @@ public class WorkloadStat implements Serializable {
private long numUpdates = 0L;
- private HashMap<String, Pair<String, Long>> insertLocationToCount;
+ private final HashMap<String, Pair<String, Long>> insertLocationToCount;
Review Comment:
I think for any class that already has final variables, it is safe to add
additional `final` variables. Otherwise, we need to be careful around the
`Serializable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
