yihua commented on code in PR #12524:
URL: https://github.com/apache/hudi/pull/12524#discussion_r1899351251
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -1444,11 +1444,8 @@ private boolean assertBaseFilesEquality(FileSlice
fileSlice1, FileSlice fileSlic
return baseFile1.getFileName().equals(baseFile2.getFileName()) &&
baseFile1.getFileId().equals(baseFile2.getFileId())
&& baseFile1.getFileSize() == baseFile2.getFileSize();
} else {
- if (!fileSlice1.getBaseFile().isPresent() ==
fileSlice2.getBaseFile().isPresent()) {
- return false;
- }
+ return fileSlice1.getBaseFile().isPresent() ==
!fileSlice2.getBaseFile().isPresent();
Review Comment:
Should this be:
```suggestion
return fileSlice1.getBaseFile().isPresent() ==
fileSlice2.getBaseFile().isPresent();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
