nsivabalan commented on code in PR #12600:
URL: https://github.com/apache/hudi/pull/12600#discussion_r1920596710
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -179,7 +179,7 @@ public class HoodieWriteConfig extends HoodieConfig {
// This ConfigProperty is also used in SQL options which expect String type
public static final ConfigProperty<String> RECORD_MERGE_MODE = ConfigProperty
.key("hoodie.write.record.merge.mode")
- .defaultValue(RecordMergeMode.EVENT_TIME_ORDERING.name())
+ .noDefaultValue("COMMIT_TIME_ORDERING if ordering field is not set;
EVENT_TIME_ORDERING if ordering field is set")
Review Comment:
is it not possible to write an infer func for deducing the default
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -754,8 +755,10 @@ public String getRecordMergeStrategyId() {
* Infers the merging behavior based on what the user sets (or doesn't set).
* Validates that the user has not set an illegal combination of configs
*/
- public static Triple<RecordMergeMode, String, String>
inferCorrectMergingBehavior(RecordMergeMode recordMergeMode, String
payloadClassName,
-
String recordMergeStrategyId) {
+ public static Triple<RecordMergeMode, String, String>
inferCorrectMergingBehavior(RecordMergeMode recordMergeMode,
Review Comment:
for eg, what does it mean if someone sets strategy id w/o setting merge
mode. or are there conflicting values for merge mode and merge strategy that
user can set
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -754,8 +755,10 @@ public String getRecordMergeStrategyId() {
* Infers the merging behavior based on what the user sets (or doesn't set).
* Validates that the user has not set an illegal combination of configs
*/
- public static Triple<RecordMergeMode, String, String>
inferCorrectMergingBehavior(RecordMergeMode recordMergeMode, String
payloadClassName,
-
String recordMergeStrategyId) {
+ public static Triple<RecordMergeMode, String, String>
inferCorrectMergingBehavior(RecordMergeMode recordMergeMode,
Review Comment:
is there a good java docs on relation b/w merge mode and merge strategy id.
it always confuses me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
