yihua commented on code in PR #12600:
URL: https://github.com/apache/hudi/pull/12600#discussion_r1927588979
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -754,8 +755,10 @@ public String getRecordMergeStrategyId() {
* Infers the merging behavior based on what the user sets (or doesn't set).
* Validates that the user has not set an illegal combination of configs
*/
- public static Triple<RecordMergeMode, String, String>
inferCorrectMergingBehavior(RecordMergeMode recordMergeMode, String
payloadClassName,
-
String recordMergeStrategyId) {
+ public static Triple<RecordMergeMode, String, String>
inferCorrectMergingBehavior(RecordMergeMode recordMergeMode,
Review Comment:
Here's the documentation on merge mode and merge strategy ID:
https://hudi.apache.org/docs/record_merger . LMK if there's any improvement we
can make.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -198,7 +198,8 @@ public class HoodieTableConfig extends HoodieConfig {
public static final ConfigProperty<RecordMergeMode> RECORD_MERGE_MODE =
ConfigProperty
.key("hoodie.record.merge.mode")
- .defaultValue(RecordMergeMode.EVENT_TIME_ORDERING)
+ .defaultValue((RecordMergeMode) null,
+ "COMMIT_TIME_ORDERING if precombine is not set; EVENT_TIME_ORDERING
if precombine is set")
Review Comment:
Makes sense. I'll take a stab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
