yihua commented on code in PR #12600:
URL: https://github.com/apache/hudi/pull/12600#discussion_r1927585837
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -179,7 +179,7 @@ public class HoodieWriteConfig extends HoodieConfig {
// This ConfigProperty is also used in SQL options which expect String type
public static final ConfigProperty<String> RECORD_MERGE_MODE = ConfigProperty
.key("hoodie.write.record.merge.mode")
- .defaultValue(RecordMergeMode.EVENT_TIME_ORDERING.name())
+ .noDefaultValue("COMMIT_TIME_ORDERING if ordering field is not set;
EVENT_TIME_ORDERING if ordering field is set")
Review Comment:
This depends on the table config which might not be available from the write
config alone, so I'm leaving that alone for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
