yihua commented on code in PR #12888:
URL: https://github.com/apache/hudi/pull/12888#discussion_r1981936302
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/HoodieCompactor.java:
##########
@@ -146,7 +146,7 @@ public HoodieData<WriteStatus> compact(
boolean useFileGroupReaderBasedCompaction =
context.supportsFileGroupReader() // the engine needs to support fg reader
first
&& !metaClient.isMetadataTable()
- &&
config.getBooleanOrDefault(HoodieReaderConfig.FILE_GROUP_READER_ENABLED)
+ &&
HoodieReaderConfig.isFileGroupReaderEnabled(metaClient.getTableConfig().getTableVersion(),
config)
Review Comment:
The file group reader `HoodieFileGroupReader` should be the only way of
reading records from a file group eventually. Let's keep that goal in mind and
do not introduce any new fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
