lokeshj1703 commented on code in PR #12888:
URL: https://github.com/apache/hudi/pull/12888#discussion_r1986669996
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java:
##########
@@ -109,9 +109,6 @@ public Option<HoodieCompactionPlan> execute() {
.getWriteTimeline().filterCompletedAndCompactionInstants().getInstantsAsStream()
.filter(instant -> compareTimestamps(instant.requestedTime(),
GREATER_THAN_OR_EQUALS, instantTime))
.collect(Collectors.toList());
- ValidationUtils.checkArgument(conflictingInstants.isEmpty(),
Review Comment:
This was failing due to MDT compaction scheduling with table version 6. This
was not related to table version 8.
If we delete compaction completed instant in DT but the corresponding
deltacommit still exists in MDT. The MDT writer goes and tries to create
compaction instant in MDT using time - one minus the inflight instant and fails
check in this PR.
DT
dc10
dc20.inf
MDT
dc10
dc20
dc19 - compaction fails since dc20 already exists.
This check wouldn't have failed with older compaction scheduling logic of
MDT where compaction instant is created using suffix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
