nsivabalan commented on code in PR #12888:
URL: https://github.com/apache/hudi/pull/12888#discussion_r1985816074
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java:
##########
@@ -109,9 +109,6 @@ public Option<HoodieCompactionPlan> execute() {
.getWriteTimeline().filterCompletedAndCompactionInstants().getInstantsAsStream()
.filter(instant -> compareTimestamps(instant.requestedTime(),
GREATER_THAN_OR_EQUALS, instantTime))
.collect(Collectors.toList());
- ValidationUtils.checkArgument(conflictingInstants.isEmpty(),
Review Comment:
nope. this piece of code was added back by me just for table version 6.
https://github.com/apache/hudi/pull/12805/files
I added 2 validations as part of that patch. And @lokeshj1703 is removing
the 2nd one from it.
@lokeshj1703 : can you help us understand why do we need to remove the
validation?
If there was a test written specifically targetted for table version 8, but
when you tried to run it against table version 6 and it failed -> And to get
the test to succeed, if we are removing this validation, its not something that
we wanted to do.
Lets reason about table version 6 and take a call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
