lokeshj1703 commented on code in PR #12888:
URL: https://github.com/apache/hudi/pull/12888#discussion_r1986673225


##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -632,6 +637,7 @@ static boolean validateConfigVersion(ConfigProperty<?> 
configProperty, HoodieTab
     // validate that the table version is greater than or equal to the config 
version
     HoodieTableVersion firstVersion = 
HoodieTableVersion.fromReleaseVersion(configProperty.getSinceVersion().get());
     boolean valid = tableVersion.greaterThan(firstVersion) || 
tableVersion.equals(firstVersion);
+    valid = valid || 
CONFIGS_REQUIRED_FOR_OLDER_VERSIONED_TABLES.contains(configProperty.key());

Review Comment:
   These configs are added with since version 1.0.0 but are still required for 
table version 6. Therefore I had to add a check here so that these configs are 
not dropped for tables with version 6.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to