the-other-tim-brown commented on code in PR #12982:
URL: https://github.com/apache/hudi/pull/12982#discussion_r2023861612
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -815,30 +816,20 @@ public final Stream<HoodieBaseFile>
getLatestBaseFilesInRange(List<String> commi
@Override
public void loadAllPartitions() {
- try {
- readLock.lock();
Review Comment:
This is writing, not reading. Write lock is taken when writing to the map.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -815,30 +816,20 @@ public final Stream<HoodieBaseFile>
getLatestBaseFilesInRange(List<String> commi
@Override
public void loadAllPartitions() {
- try {
- readLock.lock();
- ensureAllPartitionsLoadedCorrectly();
- } finally {
- readLock.unlock();
- }
+ ensureAllPartitionsLoadedCorrectly();
}
@Override
public void loadPartitions(List<String> partitionPaths) {
- try {
- readLock.lock();
Review Comment:
Similarly this is writing and not reading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
