the-other-tim-brown commented on code in PR #12982:
URL: https://github.com/apache/hudi/pull/12982#discussion_r2023879232
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java:
##########
@@ -398,14 +398,24 @@ protected Option<Pair<String, CompactionOperation>>
getPendingLogCompactionOpera
@Override
protected boolean isPartitionAvailableInStore(String partitionPath) {
- return partitionToFileGroupsMap.containsKey(partitionPath);
+ try {
+ readLock.lock();
+ return partitionToFileGroupsMap.containsKey(partitionPath);
Review Comment:
I don't think this is true, why does it matter if it is internal? The call
to this method can happen outside of the read lock and it is requiring a read
from the map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
