danny0405 commented on code in PR #12982:
URL: https://github.com/apache/hudi/pull/12982#discussion_r2023874221
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/RocksDbBasedFileSystemView.java:
##########
@@ -269,41 +269,51 @@ protected Option<Pair<String, CompactionOperation>>
getPendingLogCompactionOpera
@Override
protected boolean isPartitionAvailableInStore(String partitionPath) {
- String lookupKey = schemaHelper.getKeyForPartitionLookup(partitionPath);
- Serializable obj =
rocksDB.get(schemaHelper.getColFamilyForStoredPartitions(), lookupKey);
- return obj != null;
+ try {
+ readLock.lock();
Review Comment:
I don't think we should add any lock to protected scope methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
