nsivabalan commented on code in PR #13098:
URL: https://github.com/apache/hudi/pull/13098#discussion_r2034186988
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -226,25 +227,25 @@ public static HoodieArchivedMetaEntry createMetaWrapper(
}
case HoodieTimeline.ROLLBACK_ACTION: {
archivedMetaWrapper.setHoodieRollbackMetadata(
-
metaClient.getActiveTimeline().readRollbackMetadata(hoodieInstant));
+
metaClient.getArchivedTimeline().readRollbackMetadata(hoodieInstant));
archivedMetaWrapper.setActionType(ActionType.rollback.name());
break;
}
case HoodieTimeline.SAVEPOINT_ACTION: {
archivedMetaWrapper.setHoodieSavePointMetadata(
-
metaClient.getActiveTimeline().readSavepointMetadata(hoodieInstant));
+
metaClient.getArchivedTimeline().readSavepointMetadata(hoodieInstant));
archivedMetaWrapper.setActionType(ActionType.savepoint.name());
break;
}
case HoodieTimeline.COMPACTION_ACTION: {
// should be handled by commit_action branch though, this logic is
redundant.
- HoodieCompactionPlan plan =
CompactionUtils.getCompactionPlan(metaClient, hoodieInstant);
+ HoodieCompactionPlan plan =
CompactionUtils.getCompactionPlan(metaClient, new
ByteArrayInputStream(planBytes.get()));
Review Comment:
lets file a tracking ticket to use stream based read instead of using byte
arrays directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
