nsivabalan commented on code in PR #13098:
URL: https://github.com/apache/hudi/pull/13098#discussion_r2034196826
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -186,8 +188,9 @@ public static HoodieArchivedMetaEntry createMetaWrapper(
break;
}
case HoodieTimeline.COMMIT_ACTION: {
- getCommitMetadata(metaClient, hoodieInstant,
HoodieCommitMetadata.class)
- .ifPresent(commitMetadata ->
archivedMetaWrapper.setHoodieCommitMetadata(convertCommitMetadataToAvro(commitMetadata)));
+ HoodieCommitMetadata commitMetadata =
metaClient.getCommitMetadataSerDe().deserialize(hoodieInstant, new
ByteArrayInputStream(instantDetails.get()),
Review Comment:
hey @Davis-Zhang-Onehouse : We already have a generic record after reading
from lsm timeline. So, all required info is in memory. So, we are directly
using that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
