the-other-tim-brown commented on code in PR #13098:
URL: https://github.com/apache/hudi/pull/13098#discussion_r2034340571
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -211,13 +215,14 @@ public static HoodieArchivedMetaEntry createMetaWrapper(
}
case HoodieTimeline.REPLACE_COMMIT_ACTION:
case HoodieTimeline.CLUSTERING_ACTION: {
- getCommitMetadata(metaClient, hoodieInstant,
HoodieReplaceCommitMetadata.class)
- .ifPresent(replaceCommitMetadata ->
archivedMetaWrapper.setHoodieReplaceCommitMetadata(convertCommitMetadataToAvro(replaceCommitMetadata)));
+ HoodieCommitMetadata replaceCommitMetadata =
metaClient.getCommitMetadataSerDe().deserialize(hoodieInstant, new
ByteArrayInputStream(instantDetails.get()),
+ () -> instantDetails.get().length == 0,
HoodieReplaceCommitMetadata.class);
+
archivedMetaWrapper.setHoodieReplaceCommitMetadata(convertCommitMetadataToAvro(replaceCommitMetadata));
// inflight replacecommit files have the same metadata body as
HoodieCommitMetadata
// so we could re-use it without further creating an inflight
extension.
// Or inflight replacecommit files are empty under clustering
circumstance
- Option<HoodieCommitMetadata> inflightCommitMetadata =
getCommitMetadata(metaClient, hoodieInstant, HoodieCommitMetadata.class);
+ Option<HoodieCommitMetadata> inflightCommitMetadata =
getInflightCommitMetadata(metaClient, hoodieInstant, instantDetails);
Review Comment:
This mentions inflight, should that use `planBytes` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
