linliu-code commented on code in PR #12866:
URL: https://github.com/apache/hudi/pull/12866#discussion_r2105660916
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHFileConfig.java:
##########
@@ -47,12 +47,12 @@ public class HoodieHFileConfig {
private final CellComparator hfileComparator;
private final String keyFieldName;
- public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm
compressionAlgorithm, int blockSize,
- long maxFileSize, String keyFieldName,
+ public HoodieHFileConfig(StorageConfiguration storageConf, CompressionCodec
compressionCodec,
+ int blockSize, long maxFileSize, String
keyFieldName,
boolean prefetchBlocksOnOpen, boolean
cacheDataInL1, boolean dropBehindCacheCompaction,
BloomFilter bloomFilter, CellComparator
hfileComparator) {
- this.hadoopConf = hadoopConf;
- this.compressionAlgorithm = compressionAlgorithm;
+ this.hadoopConf = (Configuration)
storageConf.unwrapAs(Configuration.class);
Review Comment:
yeah, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
