yihua commented on code in PR #12866: URL: https://github.com/apache/hudi/pull/12866#discussion_r2105660938
########## hudi-io/src/main/java/org/apache/hudi/io/hfile/HFileWriterImpl.java: ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.io.hfile; + +import org.apache.hudi.common.util.StringUtils; +import org.apache.hudi.common.util.io.ByteBufferBackedInputStream; +import org.apache.hudi.io.ByteArraySeekableDataInputStream; +import org.apache.hudi.io.compress.CompressionCodec; +import org.apache.hudi.io.hfile.protobuf.generated.HFileProtos; + +import com.google.protobuf.ByteString; +import com.google.protobuf.CodedOutputStream; + +import java.io.ByteArrayOutputStream; +import java.io.DataOutputStream; +import java.io.IOException; +import java.io.OutputStream; +import java.nio.ByteBuffer; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; + +import static org.apache.hudi.io.hfile.DataSize.SIZEOF_INT16; + +/** + * Pure Java implementation of HFile writer (HFile v3 format) for Hudi. + */ +public class HFileWriterImpl implements HFileWriter { Review Comment: For this, we can generate a HFile using HBase-based HFile writer, add it as a test artifact (`test/resources/hfile/from_hbase_writer.hfile`) and add a unit/functional tests that generates a HFile using the new native HFile writer and compare the generated HFile with `from_hbase_writer.hfile` to make sure any change to the HFile writer that lead to storage byte change should be caught (we should also add the HFile generated by the native writer too so that byte-by-byte there is no change unless intended). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
