yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2105684484
##########
hudi-client/hudi-client-common/pom.xml:
##########
@@ -131,6 +131,12 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
Review Comment:
What is this used for?
##########
hudi-client/hudi-java-client/pom.xml:
##########
@@ -99,6 +99,12 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <version>${hadoop.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
If `org.apache.hadoop:hadoop-mapreduce-client-core` becomes a common test
dependency, it's better to add it to `hudi-tests-common` module.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -78,7 +77,7 @@ public class HoodieIndexConfig extends HoodieConfig {
.key("hoodie.index.type")
// Builder#getDefaultIndexType has already set it according to engine
type
.noDefaultValue()
- .withValidValues(HBASE.name(), INMEMORY.name(), BLOOM.name(),
GLOBAL_BLOOM.name(),
+ .withValidValues(INMEMORY.name(), BLOOM.name(), GLOBAL_BLOOM.name(),
Review Comment:
In the PR description, could you describe such changes that are user-facing?
##########
hudi-client/hudi-flink-client/pom.xml:
##########
@@ -158,36 +158,6 @@
<scope>test</scope>
</dependency>
- <!-- HBase - Tests -->
- <dependency>
- <groupId>org.apache.hbase</groupId>
Review Comment:
Have you searched the `HBase` and `hbase` keyword and verified the
dependency tree to make sure every place HBase dependency is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
