yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2105689442
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java:
##########
Review Comment:
Let's move this class to `hudi-common` module.
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/fs/inline/TestInLineFileSystemHFileInLiningBase.java:
##########
Review Comment:
We can keep the `TestInLineFileSystemWithHFileReader` class and remove this
one, i.e., merging them into one class for HFile tests. Similar for other
HFile test classes.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java:
##########
@@ -31,7 +29,7 @@ public class HFileBootstrapIndex {
* This class is explicitly used as Key Comparator to workaround hard coded
* legacy format class names inside HBase. Otherwise we will face issues
with shading.
*/
- public static class HoodieKVComparator extends CellComparatorImpl {
+ public static class HoodieKVComparator {
Review Comment:
We can remove this class now.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHFileConfig.java:
##########
Review Comment:
Let's move this class to `hudi-common` module.
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/io/hadoop/TestHoodieHBaseHFileReaderWriter.java:
##########
Review Comment:
Check if there's any test logic to migrate to the test classes using native
HFile reader and writer.
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/io/hadoop/TestHoodieHFileReaderWriterBase.java:
##########
@@ -144,7 +142,7 @@ protected void verifyMetadata(HoodieStorage storage) throws
IOException {
protected void verifySchema(HoodieStorage storage, String schemaPath) throws
IOException {
try (HoodieAvroFileReader reader = createReader(storage)) {
assertEquals(
- getSchemaFromResource(TestHoodieHBaseHFileReaderWriter.class,
schemaPath),
+ getSchemaFromResource(HFileReaderImpl.class, schemaPath),
Review Comment:
Use test class instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
