yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2105688344
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java:
##########
@@ -236,7 +236,7 @@ public void
testUpsertPartitionerWithSmallFileHandlingWithInflightCompactionWith
HoodieWriteConfig config = makeHoodieClientConfigBuilder()
.withCompactionConfig(HoodieCompactionConfig.newBuilder().compactionSmallFileSize(1024).build())
.withIndexConfig(HoodieIndexConfig.newBuilder()
- .withIndexType(HoodieIndex.IndexType.HBASE)
+ .withIndexType(HoodieIndex.IndexType.INMEMORY)
Review Comment:
Should this used global index like GLOBAL_SIMPLE?
##########
hudi-common/src/test/java/org/apache/hudi/io/storage/TestHoodieReaderWriterUtils.java:
##########
Review Comment:
We should also remove `resources/hbase-site.xml`.
##########
hudi-flink-datasource/hudi-flink/pom.xml:
##########
@@ -449,5 +449,9 @@
<version>1.3</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.validation</groupId>
+ <artifactId>validation-api</artifactId>
Review Comment:
Check this dependency addition
##########
hudi-common/pom.xml:
##########
@@ -354,5 +311,9 @@
<artifactId>tally-core</artifactId>
<version>${tally.version}</version>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ </dependency>
Review Comment:
Where is this used?
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java:
##########
@@ -311,7 +311,7 @@ public void
testUpsertPartitionerWithSmallFileHandlingWithCanIndexLogFiles() thr
.withCompactionConfig(HoodieCompactionConfig.newBuilder().compactionSmallFileSize(1024).build())
.withStorageConfig(HoodieStorageConfig.newBuilder().parquetMaxFileSize(1024).build())
.withIndexConfig(HoodieIndexConfig.newBuilder()
- .withIndexType(HoodieIndex.IndexType.HBASE)
+ .withIndexType(HoodieIndex.IndexType.INMEMORY)
Review Comment:
Similar here
##########
hudi-examples/hudi-examples-java/pom.xml:
##########
@@ -154,5 +154,9 @@
<version>${parquet.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ </dependency>
Review Comment:
Check this dependency addition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
