danny0405 commented on code in PR #13340:
URL: https://github.com/apache/hudi/pull/13340#discussion_r2113074460
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1015,17 +997,19 @@ String startCommit(Option<String> providedInstantTime,
String actionType, Hoodie
* @param extraMetadata Extra Metadata to be stored
*/
public Option<String> scheduleCompaction(Option<Map<String, String>>
extraMetadata) throws HoodieIOException {
- String instantTime = createNewInstantTime();
- return scheduleCompactionAtInstant(instantTime, extraMetadata) ?
Option.of(instantTime) : Option.empty();
+ return scheduleTableService(Option.empty(), extraMetadata,
TableServiceType.COMPACT);
}
/**
* Schedules a new compaction instant with passed-in instant time.
* @param instantTime Compaction Instant Time
* @param extraMetadata Extra Metadata to be stored
+ * @deprecated As of release 1.1.0, use {@link #scheduleCompaction(Option)}
instead.
+ * The instant time must be generated within the same lock as the plan for
proper consistency guarantees.
*/
+ @Deprecated
Review Comment:
looks like MDT still needs it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
