danny0405 commented on code in PR #13340:
URL: https://github.com/apache/hudi/pull/13340#discussion_r2113097465
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -226,17 +220,13 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
cleanStats,
cleanerPlan.getExtraMetadata()
);
- if (!skipLocking) {
- this.txnManager.beginTransaction(Option.of(inflightInstant),
Option.empty());
- }
+ this.txnManager.beginTransaction(Option.of(inflightInstant),
Option.empty());
Review Comment:
hmm, since the outer lock was removed for clean table service, so it makes
sense we always add a lock here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
