the-other-tim-brown commented on code in PR #13340:
URL: https://github.com/apache/hudi/pull/13340#discussion_r2114084629
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -226,17 +220,13 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
cleanStats,
cleanerPlan.getExtraMetadata()
);
- if (!skipLocking) {
- this.txnManager.beginTransaction(Option.of(inflightInstant),
Option.empty());
- }
+ this.txnManager.beginTransaction(Option.of(inflightInstant),
Option.empty());
Review Comment:
The `skipLocking` is always false on master so it is more so that it didn't
make sense to keep this option and run the risk of another developer setting
this to `true` and causing issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
