wombatu-kun commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2120067475
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieBloomFilterWriteSupport.java:
##########
@@ -55,15 +55,19 @@ public HoodieBloomFilterWriteSupport(BloomFilter
bloomFilter) {
public void addKey(T recordKey) {
bloomFilter.add(getUTF8Bytes(recordKey));
- if (minRecordKey == null || minRecordKey.compareTo(recordKey) > 0) {
+ if (minRecordKey == null || compareRecordKey(minRecordKey, recordKey) > 0)
{
Review Comment:
It's `hudi-common` module, this method is called not only from Spark, but
from `hudi-flink-client` and `hudi-hadoop-common`, so the `HoodieUTF8StringKey`
can not be passed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
