wombatu-kun commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2120139709
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/BaseSparkInternalRowReaderContext.java:
##########
@@ -151,4 +152,10 @@ public Comparable convertValueToEngineType(Comparable
value) {
}
return value;
}
+
+ @Override
+ public int compareValues(Comparable a, Comparable b) {
+ // [SPARK-46832] UTF8String doesn't support compareTo anymore
+ return SparkSortUtils.compareValues(a, b);
Review Comment:
Ugh.. it's not a leaf class in hierarchy, so If we implement
`Spark3InternalRowReaderContext` and `Spark4InternalRowReaderContext` we'll
have to implement also `SparkFileFormatInternalRowReaderContext` for both of
them (as now it extends `BaseSparkInternalRowReaderContext`). I think this tiny
method does not cost such a complication of class hierarchy. Now
`SparkSortUtil` is deleted, SparkAdapter is called right from here, the purpose
of this method is clear enough, may be we could leave it as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
