wombatu-kun commented on code in PR #12772: URL: https://github.com/apache/hudi/pull/12772#discussion_r2120341657
########## hudi-spark-datasource/hudi-spark4.0.x/src/main/antlr4/imports/SqlBase.g4: ########## Review Comment: > If there are changes compared to `hudi-spark3.5.x`, could you mark the changes in this PR? Changes: - `HoodieSpark40CatalystPlanUtils`: line 42, method `unapplyMergeIntoTable` (7 params in pattern matching instead of 6) - `HoodieSpark4_0ExtendedSqlParser`: line 116 (instantiating of `ParseException` is different) - `HoodieSpark4_0ExtendedSqlAstBuilder`: lines 517, 1786, 3320 - `Spark40LegacyHoodieParquetFileFormat`: method `buildReaderWithPartitionValues` - `Spark4_0Adapter`: method `getSchema`, return types of other methods are version specific Other classes in module are the same or nearly the same as in `hudi-spark3.5.x`, but we can't move them to `hudi-spark-common` because they have differences with `hudi-spark3.4.x` or `hudi-spark3.3.x`. Also added this info to PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
