the-other-tim-brown commented on code in PR #13305:
URL: https://github.com/apache/hudi/pull/13305#discussion_r2122506445
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -257,9 +273,19 @@ public boolean isTrackingSuccessfulWrites() {
return trackSuccessRecords;
}
+ public void setIsMetadata(boolean isMetadataTable) {
+ this.isMetadataTable = isMetadataTable;
+ }
+
+ public boolean isMetadataTable() {
+ return isMetadataTable;
+ }
+
@Override
public String toString() {
- return "WriteStatus {" + "fileId=" + fileId
+ return "WriteStatus {"
+ + "isMetadata=" + isMetadataTable
Review Comment:
+1, metadata is an overloaded term. Can we do something like
`updatesMetadataTable` to better capture that the write status applies to an
update to the metadata table itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
