nsivabalan commented on code in PR #13305:
URL: https://github.com/apache/hudi/pull/13305#discussion_r2122916259
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -181,6 +188,15 @@ private void updateStatsForFailure() {
totalErrorRecords++;
}
+ public void removeMetadataStats() {
+ this.writtenRecordDelegates.clear();
+ this.stat.removeRecordStats();
Review Comment:
currently we are reusing existing data structures.
since in first phase, we only plan to target RLI for streaming writes.
in subsequent patches, we will be adding secondary index, col stats etc.
So, when we plan to add more stats, we will enhance this to move all stats
to something called IndexStats.
currently, it does not makes sense to just move one entry i.e.
writtenRecordDelegates to a new class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
