lokeshj1703 commented on code in PR #13305:
URL: https://github.com/apache/hudi/pull/13305#discussion_r2124476013


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -257,9 +273,19 @@ public boolean isTrackingSuccessfulWrites() {
     return trackSuccessRecords;
   }
 
+  public void setIsMetadata(boolean isMetadataTable) {

Review Comment:
   Addressed



##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java:
##########
@@ -344,4 +375,18 @@ public void setTotalCreateTime(long totalCreateTime) {
       this.totalCreateTime = totalCreateTime;
     }
   }
+
+  private static Map<String, HoodieColumnRangeMetadata<Comparable>> 
mergeRecordsStats(
+      Map<String, HoodieColumnRangeMetadata<Comparable>> stats1,
+      Map<String, HoodieColumnRangeMetadata<Comparable>> stats2) {
+    Map<String, HoodieColumnRangeMetadata<Comparable>> mergedStats = new 
HashMap<>(stats1);
+    for (Map.Entry<String, HoodieColumnRangeMetadata<Comparable>> entry : 
stats2.entrySet()) {
+      final String colName = entry.getKey();
+      final HoodieColumnRangeMetadata<Comparable> metadata = 
mergedStats.containsKey(colName)
+          ? HoodieColumnRangeMetadata.merge(mergedStats.get(colName), 
entry.getValue())
+          : entry.getValue();
+      mergedStats.put(colName, metadata);

Review Comment:
   Addressed



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -257,9 +273,19 @@ public boolean isTrackingSuccessfulWrites() {
     return trackSuccessRecords;
   }
 
+  public void setIsMetadata(boolean isMetadataTable) {
+    this.isMetadataTable = isMetadataTable;
+  }
+
+  public boolean isMetadataTable() {
+    return isMetadataTable;
+  }
+
   @Override
   public String toString() {
-    return "WriteStatus {" + "fileId=" + fileId
+    return "WriteStatus {"
+        + "isMetadata=" + isMetadataTable

Review Comment:
   Addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to