the-other-tim-brown commented on code in PR #13383:
URL: https://github.com/apache/hudi/pull/13383#discussion_r2122525529
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java:
##########
@@ -139,17 +136,15 @@ public abstract class BaseHoodieLogRecordReader<T> {
// Allows to consider inflight instants while merging log records
protected boolean allowInflightInstants;
- protected BaseHoodieLogRecordReader(HoodieReaderContext readerContext,
HoodieStorage storage, List<String> logFilePaths,
+ protected BaseHoodieLogRecordReader(HoodieReaderContext<T> readerContext,
HoodieTableMetaClient hoodieTableMetaClient, HoodieStorage storage,
List<String> logFilePaths,
boolean reverseReader, int bufferSize,
Option<InstantRange> instantRange,
boolean withOperationField, boolean
forceFullScan, Option<String> partitionNameOverride,
Option<String> keyFieldOverride, boolean
enableOptimizedLogBlocksScan, FileGroupRecordBuffer<T> recordBuffer,
boolean allowInflightInstants) {
this.readerContext = readerContext;
- this.readerSchema = readerContext.getSchemaHandler().getRequiredSchema();
+ this.readerSchema = readerContext.getSchemaHandler() != null ?
readerContext.getSchemaHandler().getRequiredSchema() : null;
this.latestInstantTime = readerContext.getLatestCommitTime();
- this.hoodieTableMetaClient = HoodieTableMetaClient.builder()
- .setStorage(storage)
- .setBasePath(readerContext.getTablePath()).build();
+ this.hoodieTableMetaClient = hoodieTableMetaClient;
Review Comment:
we already send over the full meta client to the HoodieFileGroupReader so we
are not incurring any new cost here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
