the-other-tim-brown commented on code in PR #13383:
URL: https://github.com/apache/hudi/pull/13383#discussion_r2127198585
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1701,31 +1677,38 @@ private static
List<HoodieColumnRangeMetadata<Comparable>> readColumnRangeMetada
* Read column range metadata from log file.
*/
@VisibleForTesting
- public static List<HoodieColumnRangeMetadata<Comparable>>
getLogFileColumnRangeMetadata(String filePath, HoodieTableMetaClient
datasetMetaClient,
+ public static List<HoodieColumnRangeMetadata<Comparable>>
getLogFileColumnRangeMetadata(String filePath, String partitionPath,
+
HoodieTableMetaClient datasetMetaClient,
List<String> columnsToIndex, Option<Schema> writerSchemaOpt,
int maxBufferSize) throws IOException {
if (writerSchemaOpt.isPresent()) {
List<Pair<String, Schema.Field>> fieldsToIndex =
columnsToIndex.stream().map(fieldName ->
HoodieAvroUtils.getSchemaForField(writerSchemaOpt.get(), fieldName))
.collect(Collectors.toList());
// read log file records without merging
- List<HoodieRecord> records = new ArrayList<>();
- HoodieUnMergedLogRecordScanner scanner =
HoodieUnMergedLogRecordScanner.newBuilder()
- .withStorage(datasetMetaClient.getStorage())
- .withBasePath(datasetMetaClient.getBasePath())
- .withLogFilePaths(Collections.singletonList(filePath))
- .withBufferSize(maxBufferSize)
-
.withLatestInstantTime(datasetMetaClient.getActiveTimeline().getCommitsTimeline().lastInstant().get().requestedTime())
- .withReaderSchema(writerSchemaOpt.get())
- .withTableMetaClient(datasetMetaClient)
- .withLogRecordScannerCallback(records::add)
+ HoodieLogFile logFile = new HoodieLogFile(filePath);
+ FileSlice fileSlice = new FileSlice(partitionPath,
logFile.getDeltaCommitTime(), logFile.getFileId());
+ fileSlice.addLogFile(logFile);
+ TypedProperties properties = new TypedProperties();
+ properties.setProperty(MAX_MEMORY_FOR_MERGE.key(),
Long.toString(maxBufferSize));
+ // Currently only avro is fully supported for extracting column ranges
(see HUDI-8585)
+ HoodieReaderContext readerContext = new
HoodieAvroReaderContext(datasetMetaClient.getStorageConf(),
datasetMetaClient.getTableConfig(), Option.empty(), Option.empty());
+ HoodieFileGroupReader fileGroupReader =
HoodieFileGroupReader.newBuilder()
+ .withReaderContext(readerContext)
Review Comment:
Similar to https://github.com/apache/hudi/pull/13383/files#r2127196925 -
there is a missing property that I just pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
